[ http://issues.apache.org/jira/browse/JAMES-488?page=comments#action_12378668 ]
Stefano Bagnara commented on JAMES-488: --------------------------------------- I just looked at the patch file, (not imported, not tested). I see you converted a "private static class" into a "private class". We should damn Sun for using the static identifier with totally different meanings for methods and classes, but there is no reason to make that class static. In fact, removing the static modifier means that the "inner" object keeps a reference to the object that created it. It should work fine keeping the static modifier in the private class. > Remove static access of DNSServer > --------------------------------- > > Key: JAMES-488 > URL: http://issues.apache.org/jira/browse/JAMES-488 > Project: James > Type: Improvement > Components: DNSServer > Reporter: Norman Maurer > Assignee: Norman Maurer > Attachments: DNSServer-not-static-usage.patch > > We should remove all static access to DNSServer and move the methods to the > DNSServer interface. After that we should be able to acces this via the > interface Serviceable. > This will it make easier to write junit tests etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
