Serge Knystautas wrote:
Stefano,
I'm having trouble determining whether I think this is a helpful
refactoring based on the diffs. Do you have a before and after
view?... maybe ViewSVN link to the point before you started to
changes, and then a download of the source afterward?
If you have a local checkout of the current trunk it's just a matter of
applying the patch.
Btw, here is the viewvc of the current trunk fetchmail
http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/fetchmail/
And here are the sources after the patch:
http://people.apache.org/~bago/james/fetchmail-refactoring2-resulting-code.zip
Keep in mind that it is a work-in-progress, just to illustrate the
"major" changes: if we'll come to consensus it will need few more work
at least to update comments and other minor issues.
I like the idea of making the code formatted in a consistent pattern.
I didn't finished it, btw I think that it worth doing it if we already
apply major changes to the code.
Reformatting is a bad thing to keep track of history of the code, but
this could be a good opportunity to do that at least in fetchmail.
In terms of design patterns, I really don't care... I appreciate you
using a review-then-commit rather than commit-then-review on a change
this substantial (at least in # lines affected).
I follow this "rule": am I the only committer activerly working on a
repository? Yes? Then CTR is good if I am at least 50% confident the
change will be accepted. When the number of active committers grows I
increase the needed percentage.
Btw RTC has big advantage over CTR because you can track each single
step involved in the change, you can checkout the old and the new
version and you can always revert.
I'm happy people is looking at the patch because this is a proof that it
is good to code something instead of discussing of abstract things.
As a general comment though, I trust Stefano will do a good job with
the changes or will fix it promptly if he didn't.
Thank you.
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
