Hi Stefano,
At a first look you did a really good job!
Thank you.
1) Why you introduced the StoreAware interface? It seems it is not used
in the code.
(Formally know as FolderAware) This exposes the underlaying Javamail
store. The IMAP server will depend on that until James has an own solution.
2) Is there any javamail store implementation (even not maildir) under a
compatible license that we can use for the examples in the config.xml
and for the default tests?
I fear not. There is a LGPL one but I know there are uncertainties with
LGPL, too. But I agree we need something for testing. Creating an in
memory MOCK should be very easy. (ArrayList of MimeMessages with easy
operations) We could uses a memory://blah url for that.
Another thing I have in mind is offering a javamail implementation for
James storing methods. This should be no problem, when we have made the
extensions needed for Imap. A JDBC javamail store could be in demand.
Imho the code you provided in the src folder
can be included in James, but the patch to config.xml and the tests
references the "maildir store" and the only known (to me) implementation
of the maildir store is GPL, so it would be safer for us to avoid even
this "virtual" references in our codebase.
That sounds like "persecution mania". :-) But of course it would be
dissatisfying to have untestable code. The tests should run the MOCK by
default and be configurable by a properties file.
How to actually use javamaildir could be explained on the website/faq/wiki.
BTW: classpathx has a maildir implementation, as well but it's also GPL
and has less features.
Joachim
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
