MailImpl expose internal representation on getRecipients. This is a bad
practice.
---------------------------------------------------------------------------------
Key: JAMES-558
URL: http://issues.apache.org/jira/browse/JAMES-558
Project: James
Type: Bug
Components: James Core
Reporter: Stefano Bagnara
Fix For: 3.0
Currently our getRecipients expose the internal collection and it is used that
way.
To add recipients we use getRecipients().add(), to store multiple times a
single mail to different recipients we get the recipients collection and alter
it between store of the mail object (in RemoteDelivery).
All of this seems to me bad practice and we should better encapsulate the
recipients list in the mail object.
Maybe the simple way is to return immutable collections so we'll find bugs as
soon as possible and add methods to add and remove recipients directly in the
mail interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
