On 8/21/06, Norman Maurer <[EMAIL PROTECTED]> wrote:
Am Montag, den 21.08.2006, 16:10 +0200 schrieb Bernd Fondermann:
> thanks!
>
> I have to admit that I don't understand what the fields
> repositoryPath/repository are for.
Its the url to the db.. like : db://maildb
> This is a very generic name for a variable which is _required_ to be
> configured and only used in a very limited functional domain (ham/spam
> admin). Currently, "repository" is never read and could be removed, as
> far as I can see.
its used in inizialize() and in doADDHAM and doADDSPAM
ok, I see now. But it is not used beyond initialize()... not so nice.
>
> Also, I don't like that spam administrative logic is put into the
> RemoteManager which incorporates the RM to have exact knowledge how
> the bayesian stuff is implemented (namely: SQL, JDBC). This is far
> more insight than the RM should have und would better be found in a
> separate component which hides the spam filter's implementation. Buzz
> words often used in this context: high cohesion, low coupling.
>
> This would have the advantages that the functionality is open to other
> components as well (e.g. JMX), it can be found much easier by other
> developers (when put near the bayesian code) and the RemoteManager
> stays more 'clean'.
>
> Bernd
>
Ok thats a good idea.. Can you do it ? You also did the other stuff for
jmx
if you isolate the stuff from RemoteManager, I'll do it ;-)
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
