Author: norman Date: Sun Sep 3 03:40:55 2006 New Revision: 439757 URL: http://svn.apache.org/viewvc?rev=439757&view=rev Log: Fix Nullpointer in TOP command. See JAMES-606
Modified: james/server/trunk/src/java/org/apache/james/pop3server/TopCmdHandler.java Modified: james/server/trunk/src/java/org/apache/james/pop3server/TopCmdHandler.java URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/pop3server/TopCmdHandler.java?rev=439757&r1=439756&r2=439757&view=diff ============================================================================== --- james/server/trunk/src/java/org/apache/james/pop3server/TopCmdHandler.java (original) +++ james/server/trunk/src/java/org/apache/james/pop3server/TopCmdHandler.java Sun Sep 3 03:40:55 2006 @@ -58,6 +58,14 @@ * @param argument the first argument parsed by the parseCommand method */ private void doTOP(POP3Session session,String arguments) { + String responseString = null; + + if (arguments == null) { + responseString = POP3Handler.ERR_RESPONSE + " Usage: TOP [mail number] [Line number]"; + session.writeResponse(responseString); + return; + } + String argument = ""; String argument1 = ""; int pos = arguments.indexOf(" "); @@ -65,7 +73,7 @@ argument = arguments.substring(0,pos); argument1 = arguments.substring(pos+1); } - String responseString = null; + if (session.getHandlerState() == POP3Handler.TRANSACTION) { int num = 0; int lines = 0; --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]