[ http://issues.apache.org/jira/browse/JAMES-609?page=all ]

Stefano Bagnara updated JAMES-609:
----------------------------------

    Attachment: JAMES-609.diff

This is a possible fix to the problem.
Few changes are on the tests to solve some temporary file not release (24 
before the fix, 20 after the fix).

Now that I wrote it I'm not sure about this in 2.3: they are a lot of 
changes... maybe it is better to add a check in setMessage to see if the new 
message is the same of the old one...

I have to think more about this...

> MailImpl.setMessage and possible NPE: regression from 2.2.0 and 2.3.0rc1
> ------------------------------------------------------------------------
>
>                 Key: JAMES-609
>                 URL: http://issues.apache.org/jira/browse/JAMES-609
>             Project: James
>          Issue Type: Bug
>          Components: James Core
>    Affects Versions: 2.3.0rc2
>            Reporter: Stefano Bagnara
>             Fix For: 2.3.0rc3
>
>         Attachments: JAMES-609.diff
>
>
> The change introduced in rc2 to fix the file leaks has produced an NPE in a 
> custom mailet.
> I suggest to revert the setMessage changes removing the dispose() call for 
> the old message and to put the dispose code in the bundled calling  mailets.
> This is not a good fix in the long term, but for 2.3.0 I would prefer to keep 
> compatibility with 2.2.0 and to have a leak instead of NPE (difficult to 
> understand by most users).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to