Same here.. But i think unknown whould be the best we can return.

bye
Norman

Guillermo Grandes schrieb:
mmm... "unknown", [IP] or null (compatibility)? I do not see it very clear in http://java.sun.com/j2se/1.5.0/docs/api/java/net/InetAddress.html#getHostName()

----- Original Message ----- From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Saturday, September 30, 2006 8:53 PM
Subject: svn commit: r451636 -
/james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java


Author: norman
Date: Sat Sep 30 11:53:26 2006
New Revision: 451636

URL: http://svn.apache.org/viewvc?view=rev&rev=451636
Log:
Catch UnknownHostException when try to resolve ip on init Handler. See
JAMES-646

Modified:

james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java

Modified:
james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java?view=diff&rev=451636&r1=451635&r2=451636 ==============================================================================
---
james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java
(original)
+++
james/server/trunk/src/java/org/apache/james/core/AbstractJamesHandler.java
Sat Sep 30 11:53:26 2006
@@ -43,6 +43,7 @@
import java.io.PrintWriter;
import java.net.Socket;
import java.net.SocketException;
+import java.net.UnknownHostException;

/**
 * Common Handler code
@@ -133,7 +134,11 @@
    protected void initHandler( Socket connection ) throws IOException {
        this.socket = connection;
        remoteIP = socket.getInetAddress().getHostAddress();
-        remoteHost = dnsServer.getHostName(socket.getInetAddress());
+        try {
+ remoteHost = dnsServer.getHostName(socket.getInetAddress());
+        } catch (UnknownHostException e) {
+            remoteHost = "unknown";
+        }
        try {
            synchronized (this) {
                handlerThread = Thread.currentThread();



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

!EXCUBATOR:1,451ec1e853072519838221!



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to