... 997, 998, 999, 1000 ;-)
I didn't want to flood with my concerns so I waited few days.
I just want to summarize my view and the meaning of my veto:
It is not my last word on this issue:
a) I can be convinced that I'm wrong
b) The commit has been done on v2.3: we have to separate v2.3 from
next-minor and I think they deserve different reasons.
In the middle of dozens of messages I found that Noel brough what I
consider a good argument against my veto:
"the full backport would need an assembly.xml change"
I agree that we have to do everything we can to keep assembly unchanged
in a point release 2.3.0 => 2.3.x.
That said my current idea is:
1) add the sun specific property (-D in run command line) to enable
expiration to InetAddress to all of our phoenixes (trunk/v2.3 branch)
2) backport the full fix (including my latest fixes to dnsserver) to
next-minor (I think we should try to backport things "as is" and not to
write alternative solutions to the same problem (much less code to mantain).
Please note that since this thread started I fixed 3 bugs in dnsserver
in trunk and I believe the 3 bugs are in 2.3.0 too. They are not "major"
bugs but not even trivial, so this is one more argument to backport the
complete fix.
I'm not retiring the veto now because I think it doesn't block any
release. I want to avoid to delay releases/workflow for this issue, but
I keep the veto because I think this deserve some more considerations.
What I'm trying to avoid is to have 3 different dnsservers because I
think this is really hard to be supported.
Stefano
Noel J. Bergman wrote:
Danny Angus wrote:
Noel J. Bergman wrote:
That's it. Assembly vs a static method. The only difference between
the
two code sets. That's all that we're talking about.
You're not going to draw me into a Big Debate about this ;-)
Well, I agree with you, but Stefano thinks that the difference amounts to a
technical justification to block the fix. :-)
From where I'm sitting though, static method == Bad, indirection and
separation of concerns == good.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
