Bernd Fondermann wrote:
-1. reason: from my experience, commenting out unit tests leads to a
degeneration of the test base as a whole, on the long run making the
unit tests more or less useless. a small improvement or fix does not
justify leaving our tests compromised.
Norman opened a JIRA issue assigned to Noel for this.
I think it is a good alternative to the other you're proposing.
instead, we should do one if the following
o back out the original commit causing the test to fail - bad, because
this committer does not care for the unit test, so does not care for
quality?
Noel say that trunk is not quality code, maybe he simply wants to
enforce this :-)
o fix the test immediately, because it gets harder every day it is not done
This need more time.
o let us simply have the breaking test until it gets fixed - bad,
because some tests are not run anymore but maybe we need some more
days until it gets fixed, which is fine.
Having a broken test may hide other problems arising from newer commits.
CI and Nightly builds no more give us useful output if we have a broken
test.
That said if you don't retire the veto or don't apply any of the other
solution I will try to follow the first solution (remove the patch that
broke the test). I don't like this solution but I prefer it over having
failing builds because of the failing test.
Stefano
Bernd
On 11/10/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: norman
Date: Fri Nov 10 01:37:09 2006
New Revision: 473287
URL: http://svn.apache.org/viewvc?view=rev&rev=473287
Log:
Comment a broken test
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
