I think that the 2 features are overlapping and it would be much better
to expose the simpler in config.xml and leave the other in alternative
classes/packages.
I think that an overall "connections per ip" limit is better and enough
for most users and the "connections per service per ip" won't give a
better result in most common scenarios.
My proposal is to keep the connections per ip limit in the base code and
to optionally provide classes and informations (and maybe comments in
the assembly/config.xml) to support the other.
I think that the "connection per service per ip" could be achieved by
simply creating multiple instances of the connectionManager in the
assembly and wire them in the desired way. This was already feasible
without code changes.
Either way the refactoring to remove the int<=>String conversions would
be a good improvement.
Stefano
Norman Maurer (JIRA) wrote:
[ http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12449337 ]
Norman Maurer commented on JAMES-670:
-------------------------------------
Sure its possible.. I also thought about this before i did the changes.. But
remember that whould also need changes to assembly.xml again etc... But if all
agree i can refactor it..
Per IP connection limiting is not configurable per service, nor is the
configuration logged during initialization.
------------------------------------------------------------------------------------------------------------------
Key: JAMES-670
URL: http://issues.apache.org/jira/browse/JAMES-670
Project: James
Issue Type: New Feature
Affects Versions: Next Major, Trunk
Reporter: Noel J. Bergman
Assigned To: Norman Maurer
Per IP connection limiting is not configurable per service, nor is the
configuration logged during initialization.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
