Author: norman
Date: Mon Nov 13 07:17:36 2006
New Revision: 474366
URL: http://svn.apache.org/viewvc?view=rev&rev=474366
Log:
Some small code improvments
Modified:
james/server/trunk/src/java/org/apache/james/util/connection/ConnectionPerIpMap.java
james/server/trunk/src/java/org/apache/james/util/junkscore/JunkScoreImpl.java
Modified:
james/server/trunk/src/java/org/apache/james/util/connection/ConnectionPerIpMap.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/util/connection/ConnectionPerIpMap.java?view=diff&rev=474366&r1=474365&r2=474366
==============================================================================
---
james/server/trunk/src/java/org/apache/james/util/connection/ConnectionPerIpMap.java
(original)
+++
james/server/trunk/src/java/org/apache/james/util/connection/ConnectionPerIpMap.java
Mon Nov 13 07:17:36 2006
@@ -40,7 +40,7 @@
* @param ip raise the connectionCount for the given ipAddress
*/
public synchronized void addConnectionPerIP (String ip) {
- connectionPerIP.put(ip,Integer.toString(getConnectionPerIP(ip) +1));
+ connectionPerIP.put(ip,new Integer(getConnectionPerIP(ip) +1));
}
/**
@@ -50,18 +50,11 @@
* @return count
*/
public synchronized int getConnectionPerIP(String ip) {
- int count = 0;
- String curCount = null;
- Object c = connectionPerIP.get(ip);
-
- if (c != null) {
- curCount = c.toString();
-
- if (curCount != null) {
- return Integer.parseInt(curCount);
- }
- }
- return count;
+ Integer value = (Integer) connectionPerIP.get(ip);
+ if (value == null) {
+ return 0;
+ }
+ return value.intValue();
}
/**
@@ -73,7 +66,7 @@
int count = getConnectionPerIP(ip);
if (count > 1) {
- connectionPerIP.put(ip,Integer.toString(count -1));
+ connectionPerIP.put(ip,new Integer(count -1));
} else {
// not need this entry any more
connectionPerIP.remove(ip);
Modified:
james/server/trunk/src/java/org/apache/james/util/junkscore/JunkScoreImpl.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/util/junkscore/JunkScoreImpl.java?view=diff&rev=474366&r1=474365&r2=474366
==============================================================================
---
james/server/trunk/src/java/org/apache/james/util/junkscore/JunkScoreImpl.java
(original)
+++
james/server/trunk/src/java/org/apache/james/util/junkscore/JunkScoreImpl.java
Mon Nov 13 07:17:36 2006
@@ -62,27 +62,24 @@
* @see
org.apache.james.util.junkscore.JunkScore#getStoredScore(java.lang.String)
*/
public double getStoredScore(String key) {
- Object s = scoreMap.get(key);
+ Double s = (Double) scoreMap.get(key);
- if (s != null) {
- return Double.parseDouble(s.toString());
- } else {
+ if (s == null) {
return 0;
}
+ return s.doubleValue();
}
/**
* @see
org.apache.james.util.junkscore.JunkScore#setStoredScore(java.lang.String,
double)
*/
public double setStoredScore(String key, double score) {
- Object s = null;
- s = scoreMap.put(key, String.valueOf(score));
-
- if (s == null) {
+ Double s = (Double) scoreMap.put(key, new Double(score));
+
+ if (s== null) {
return 0;
- } else {
- return Double.parseDouble(s.toString());
}
+ return s.doubleValue();
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
