On 11/22/06, Joachim Draeger <[EMAIL PROTECTED]> wrote:
Hi Bernd,
Am Mittwoch, den 22.11.2006, 09:09 +0100 schrieb Bernd Fondermann:
> > This has been fine for SMTP/ POP3/ RemoteManager because they require a
similar low timeout (e.g. <5 minutes).
> >
> > IMAP RFC3501 requires a timeout of > 30 min.
> >
> > I am not completely sure who requires this why, because there is also a
connectiontimeout enforced by a watchdog thread.
> >
> > Because I am not so familiar with SimpleConnectionManager and
AbstractService/Handler I'm going to attach a patch for review.
>
> Looks fine. For the growing connect() parameter list we could consider
> a parameter class.
Although it took me a bit time to write that patch, I decided to discard
it and doing it the DI way.
you mean using getter/setter? even better!
The original ConnectionManager doesn't even have a maxOpenConnections
option.
Today I would tend to even cut out ConnectionHandlerFactory and
ThreadPool and provide them via DI.
Well, with Phoenix I feel always a bit blind for that ideas. :-)
:-)
But yes, if we would decide to extend the connect() method, we should
use a parameter class and cut down our custom methods to one.
Even without an additional parameter (sockettimeout) it is already quite
confusing. One convenience method for every possible combination of 10
parameters. ;-)
yes. it was so nice and clean before we added those optional stuff.
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
