Tom Brown wrote:
I have submitted the code via JIRA. I believe it's issue #12359570.
Tom
First of all, thank you! It's always cool to receive code contributions!
I gave the code a really fast review and I have some comment/question:
1) I noticed a class using 2 sun.* classes.
import sun.misc.BASE64Decoder;
import sun.security.rsa.RSAPublicKeyImpl;
That code is tied to the SUN libraries.
What about using a KeyFactory to generate the RSA public key?
http://java.sun.com/j2se/1.4.2/docs/api/java/security/KeyFactory.html
2) I see you use StringBuilder so the code is tied to Java5. If we want
to make it releasable with current James we have to backport it to Java2
1.4 (replace it with StringBuffer). Is there anything else depending on
java5 ?
3) I don't know the DK specification: is it fully supported by this
code? or is it a partial implementation?
4) I don't know what are the differences between DK and DKIM: do you
plan to work also on DKIM or in any way support DKIM, too?
Stefano
PS: Robert, is this work somehow related to the reorganization of crypto
code (SMIME/PGP) discussed here
http://issues.apache.org/jira/browse/JAMES-596 ?
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
