Are you sure the problem is that charsetName is null?
Isn't instead this method called with "anychar" ?
Wouldn't it be better to catch UnsupportedCharsetException and
IllegalCharsetNameException around Charset.forName and simply leave c as
null so that the following if will simply use the already present default?
And, at the moment, I would leave the TODO there, because maybe
ISO8859-1 is not the best default for everyone.
I thought about using:
new InputStreamReader(new ByteArrayInputStream(new byte[0]).getEncoding()
But this would return UTF8 on system having a default file encoding set
to UTF8 and maybe it is not good to parse email as UTF8 when unspecified.
Any hint?
Stefano
[EMAIL PROTECTED] ha scritto:
Author: norman
Date: Mon Apr 23 05:11:16 2007
New Revision: 531444
URL: http://svn.apache.org/viewvc?view=rev&rev=531444
Log:
Use default charset of ISO8859-1 if charset could not retrived. Thx to GX; -)
Modified:
james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
Modified: james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java
URL:
http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java?view=diff&rev=531444&r1=531443&r2=531444
==============================================================================
--- james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java (original)
+++ james/mime4j/trunk/src/main/java/org/mime4j/util/CharsetUtil.java Mon Apr
23 05:11:16 2007
@@ -1119,10 +1119,11 @@
}
public static java.nio.charset.Charset getCharset(String charsetName) {
+ if(charsetName == null) charsetName = "ISO8859-1";
+
java.nio.charset.Charset c = java.nio.charset.Charset.forName(charsetName);
if (c == null) {
- //TODO: Check what touse as default
c = java.nio.charset.Charset.forName("ISO8859-1");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
