Stefano Bagnara schrieb:
> Norman Maurer ha scritto:
>   
>> [EMAIL PROTECTED] schrieb:
>>     
>>> +            if (spfData.getSenderDomain().indexOf('.') < 0) {
>>> +                throw new NoneException("Sender domain 
>>> "+spfData.getSenderDomain()+" is not an FQDN.");
>>> +            }
>>> +           
>>>   
>>>       
>> Should we use a "better" regex for FQDN detection ?
>>     
>
> Just after that test I also added a dnsjava "Name.fromString(domain)"
> that should take care of a better "check".
> We currently pass all the tests: if you can write a test we don't pass
> then we can try to fix it by improving the code ;-) (not to say that the
> code is good that way, but to say that we should prove it by creating a
> test, so we are sure we fix it correctly).
>
> Stefano
>   

Ok, I will take a deeper look tomorrow. Now I have to get ready for
party :-P

bye
Norman



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to