[ 
https://issues.apache.org/jira/browse/JAMES-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norman Maurer resolved JAMES-558.
---------------------------------

    Resolution: Duplicate

Moved to MAILET-5



> MailImpl expose internal representation on getRecipients. This is a bad 
> practice.
> ---------------------------------------------------------------------------------
>
>                 Key: JAMES-558
>                 URL: https://issues.apache.org/jira/browse/JAMES-558
>             Project: James
>          Issue Type: Bug
>          Components: James Core, Mailet API
>            Reporter: Stefano Bagnara
>         Assigned To: Norman Maurer
>             Fix For: Trunk
>
>
> Currently our getRecipients expose the internal collection and it is used 
> that way.
> To add recipients we use getRecipients().add(), to store multiple times a 
> single mail to different recipients we get the recipients collection and 
> alter it between store of the mail object (in RemoteDelivery).
> All of this seems to me bad practice and we should better encapsulate the 
> recipients list in the mail object.
> Maybe the simple way is to return immutable collections so we'll find bugs as 
> soon as possible and add methods to add and remove recipients directly in the 
> mail interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to