I just ran RAT aginast jSPF. It of course complain about this classes having the unusual header:
src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java src/test/java/org/apache/james/jspf/dnsserver/TCPListener.java src/test/java/org/apache/james/jspf/dnsserver/UDPListener.java the header: --------------- // ATTENTION PLEASE ATTENTION PLEASE ATTENTION PLEASE ATTENTION PLEASE // ATTENTION PLEASE ATTENTION PLEASE ATTENTION PLEASE ATTENTION PLEASE // // Part of this class have been inspired and copy&pasted from the jnamed.java // file found in the root of the dnsjava-2.0.5 distribution file. // // The Copyright for the original work is: // Copyright (c) 1999-2004 Brian Wellington ([EMAIL PROTECTED]) // // The License for the dnsjava-2.0.5 package is BSD ---------------- I just changed the classes adding the ASLv2 header on top of that one and leaving that one in place, too. I remember we discussed this topic in past, too, and IIRC this was an acceptable solution. Then we have problematic headers in stage/**/*.pom files, but they are third party descriptor, so we leave them as is. Then we have no headers in the test resources: !????? src/test/resources/org/apache/james/jspf/mailzone-tests.yml !????? src/test/resources/org/apache/james/jspf/pyspf-tests.yml !????? src/test/resources/org/apache/james/jspf/rfc4408-tests.yml !????? src/test/resources/org/apache/james/jspf/tests.yml !????? src/test/resources/org/apache/james/jspf/test_parser.txt !????? src/test/resources/org/apache/james/jspf/test_rfc_examples.txt rfc4408-tests has already been removed from our codebase (I have it only in my local copy so to run more tests) because the current licensing for that file is now dual licensed under the GNU GPL v2 and the Creative Commons CC BY-SA 2.5. AFAIU CC BY-SA may be ASF compatible but this is under investigation (at least it was 1 year ago). The pyspf-tests seems to be licensed under the same terms of the rfc4408-tests: should we remove this too? A weird thing about the 2 files is that they are included in the BSD licensed Mail-SPF Perl module (http://search.cpan.org/dist/Mail-SPF/). I don't know if they got a special relicensed version or if they are simply not aware of the licensing issues. The *.txt files are copied (or based on) files from dual licensed (LGPL + 2-clause BSD) libspf2 (http://www.libspf2.org/): should we add an header? Should we add a NOTICE reference for this?? The mailzone-tests.yml has been written by US based on the live mailzone.com zone content. Should we add our ASLv2 header? Stefano --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
