Author: bago
Date: Mon Sep 17 07:45:08 2007
New Revision: 576461

URL: http://svn.apache.org/viewvc?rev=576461&view=rev
Log:
Remove JavaDocs warning.

Modified:
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Inet6Util.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpand.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpandEnabled.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFSession.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/executor/SPFResult.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSJnioAsynchService.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DefaultTermsFactory.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/SPF.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/MatcherBasedConfiguration.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/RFC4408SPF1Parser.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/TermsFactory.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/PolicyPostFilter.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/DefaultExplanationPolicy.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/TrustedForwarderPolicy.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/GenericModifier.java
    james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/IP4Mechanism.java
    
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/UnknownModifier.java
    james/jspf/trunk/src/test/java/org/apache/james/jspf/AbstractYamlTest.java
    
james/jspf/trunk/src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Inet6Util.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Inet6Util.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Inet6Util.java 
(original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/Inet6Util.java 
Mon Sep 17 07:45:08 2007
@@ -27,7 +27,7 @@
  * 
  * see Inet6Util from the Apache Harmony project
  * 
- * @see org.apache.harmony.util.Inet6Util
+ * see org.apache.harmony.util.Inet6Util
  */
 public class Inet6Util {
     

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpand.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpand.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpand.java 
(original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpand.java 
Mon Sep 17 07:45:08 2007
@@ -67,8 +67,8 @@
     /**
      * Construct MacroExpand
      * 
-     * @param spfData the MacroData to use
      * @param logger the logget to use
+     * @param dnsProbe the dns service to use
      */
     public MacroExpand(Logger logger, DNSService dnsProbe) {
         // This matches 2 groups

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpandEnabled.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpandEnabled.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpandEnabled.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/MacroExpandEnabled.java
 Mon Sep 17 07:45:08 2007
@@ -28,8 +28,8 @@
     /**
      * Provide component with a DNSService.
      * 
-     * @param service
-     *            the dns service. Must not be <code>null</code>.
+     * @param macroExpand
+     *            the macroExpand service. Must not be <code>null</code>.
      */
     void enableMacroExpand(MacroExpand macroExpand);
 }

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFSession.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFSession.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFSession.java 
(original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/core/SPFSession.java 
Mon Sep 17 07:45:08 2007
@@ -86,8 +86,6 @@
      *            The helo provided by the sender
      * @param clientIP
      *            The ipaddress of the client
-     * @param dnsProbe
-     *            The DNSService
      * @throws PermErrorException
      *             Get thrown if invalid data get passed
      * @throws NoneException

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/executor/SPFResult.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/executor/SPFResult.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/executor/SPFResult.java 
(original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/executor/SPFResult.java 
Mon Sep 17 07:45:08 2007
@@ -46,8 +46,6 @@
     /**
      * Construct SPFResult
      * 
-     * @param result the result 
-     * @param explanation the explanation
      * @param spfSession the SPFSession
      */
     public SPFResult(SPFSession spfSession) {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSJnioAsynchService.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSJnioAsynchService.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSJnioAsynchService.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSJnioAsynchService.java
 Mon Sep 17 07:45:08 2007
@@ -35,68 +35,7 @@
 import org.xbill.DNS.Type;
 
 public class DNSJnioAsynchService implements DNSAsynchLookupService {
-/*
-    private final class ResponseQueueAdaptor extends ResponseQueue {
 
-        private IResponseQueue responsePool;
-
-        public ResponseQueueAdaptor(IResponseQueue responsePool) {
-            this.responsePool = responsePool;
-        }
-
-        public void insert(final Response arg0) {
-            IResponse resp = new IResponse() {
-
-                public Exception getException() {
-                    if (arg0.getException() != null) {
-                        return new DNSService.TimeoutException();
-                    } else {
-                        return null;
-                    }
-                }
-
-                public Object getId() {
-                    return arg0.getId();
-                }
-
-                public Object getValue() {
-                    Message response = arg0.getMessage();
-                    RRset[] rrs = response.getSectionRRsets(Section.ANSWER);
-                    List records = new LinkedList();
-                    for (int i = 0; i < rrs.length; i++) {
-                        for (Iterator it = rrs[i].rrs(); it.hasNext(); ) {
-                            records.add(it.next());
-                        }
-                    }
-                    return DNSServiceXBillImpl.convertRecordsToList((Record[]) 
records.toArray(new Record[]{}));
-                    
-                }
-                
-            };
-            responsePool.insertResponse(resp);
-        }
-
-        public boolean isEmpty() {
-            return responsePool.isEmpty();
-        }
-        
-        public Response getItem() {
-            IResponse found = responsePool.removeResponse();
-            Response resp = new Response();
-            if (found.getException() != null) {
-                resp.setException(true);
-                resp.setException(found.getException());
-            } else {
-                resp.setException(false);
-                resp.setMessage((Message) found.getValue());
-            }
-            resp.setId(found.getId());
-            return resp;
-        }
-        
-        
-    }
-*/
     private ExtendedNonblockingResolver resolver;
 
     public DNSJnioAsynchService(ExtendedNonblockingResolver resolver) {
@@ -116,7 +55,7 @@
     }
     
     /**
-     * @see 
org.apache.james.jspf.executor.DNSAsynchLookupService#getRecordsAsynch(org.apache.james.jspf.core.DNSRequest,
 java.lang.Object, org.apache.james.jspf.executor.IResponseQueue)
+     * @see 
org.apache.james.jspf.executor.DNSAsynchLookupService#getRecordsAsynch(org.apache.james.jspf.core.DNSRequest,
 int, org.apache.james.jspf.executor.IResponseQueue)
      */
     public void getRecordsAsynch(DNSRequest request, int id,
             IResponseQueue responsePool) {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceAsynchSimulator.java
 Mon Sep 17 07:45:08 2007
@@ -30,7 +30,6 @@
 
 /**
  * Wrap a DNSService an execute the calls asynch in a new Thread
- * 
  */
 public class DNSServiceAsynchSimulator implements Runnable, 
DNSAsynchLookupService {
 
@@ -74,7 +73,7 @@
     }
 
     /**
-     * @see 
org.apache.james.jspf.core.DNSService#getRecordsAsynch(java.lang.String, int, 
java.lang.Object, org.apache.james.jspf.executor.IResponseQueue)
+     * @see 
org.apache.james.jspf.executor.DNSAsynchLookupService#getRecordsAsynch(org.apache.james.jspf.core.DNSRequest,
 int, org.apache.james.jspf.executor.IResponseQueue)
      */
     public void getRecordsAsynch(DNSRequest request, int id,
             final IResponseQueue responsePool) {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DNSServiceXBillImpl.java
 Mon Sep 17 07:45:08 2007
@@ -72,7 +72,7 @@
     }
 
     /**
-     * @see org.apache.james.jspf.core.DNSService#getLocalDomainNames();
+     * @see org.apache.james.jspf.core.DNSService#getLocalDomainNames()
      */
     public List getLocalDomainNames() {
         List names = new ArrayList();

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DefaultTermsFactory.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DefaultTermsFactory.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DefaultTermsFactory.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/DefaultTermsFactory.java
 Mon Sep 17 07:45:08 2007
@@ -130,7 +130,7 @@
 
 
     /**
-     * @see 
org.apache.james.jspf.parser.TermsFactory#createTerm(org.apache.james.jspf.parser.TermDefinition,
 org.apache.james.jspf.core.MatcherBasedConfiguration)
+     * @see 
org.apache.james.jspf.parser.TermsFactory#createTerm(java.lang.Class, 
org.apache.james.jspf.terms.Configuration)
      */
     public Object createTerm(Class termDef, Configuration subres) throws 
PermErrorException, InstantiationException {
         try {

Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/SPF.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/SPF.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/SPF.java 
(original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/impl/SPF.java Mon Sep 
17 07:45:08 2007
@@ -341,7 +341,7 @@
 
 
     /**
-     * @see 
org.apache.james.jspf.SPFChecker#checkSPF(org.apache.james.jspf.core.SPFSession)
+     * @see 
org.apache.james.jspf.core.SPFChecker#checkSPF(org.apache.james.jspf.core.SPFSession)
      */
     public DNSLookupContinuation checkSPF(SPFSession spfData) throws 
PermErrorException,
             NoneException, TempErrorException, NeutralException {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/MatcherBasedConfiguration.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/MatcherBasedConfiguration.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/MatcherBasedConfiguration.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/MatcherBasedConfiguration.java
 Mon Sep 17 07:45:08 2007
@@ -38,8 +38,6 @@
     /**
      * @param w
      *            Original MatchResult
-     * @param zero
-     *            The original index returned when group(0) is requested
      * @param start
      *            the position where the subresult start
      * @param count

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/RFC4408SPF1Parser.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/RFC4408SPF1Parser.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/RFC4408SPF1Parser.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/RFC4408SPF1Parser.java
 Mon Sep 17 07:45:08 2007
@@ -114,7 +114,8 @@
     /**
      * Constructor. Creates all the values needed to run the parsing
      * 
-     * @param loggerThe logger to use
+     * @param logger the logger to use
+     * @param termsFactory the TermsFactory implementation
      */
     public RFC4408SPF1Parser(Logger logger, TermsFactory termsFactory) {
         this.log = logger;
@@ -248,7 +249,7 @@
     }
 
     /**
-     * @see 
org.apache.james.jspf.parser.SPFRecordParser#parse(java.lang.String)
+     * @see org.apache.james.jspf.core.SPFRecordParser#parse(java.lang.String)
      */
     public SPF1Record parse(String spfRecord) throws PermErrorException,
             NoneException, NeutralException {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/TermsFactory.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/TermsFactory.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/TermsFactory.java 
(original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/parser/TermsFactory.java 
Mon Sep 17 07:45:08 2007
@@ -33,7 +33,7 @@
     /**
      * Create a new term starting from the TermDefinition created by this 
factory
      * 
-     * @param class the TermDefinition.getTermDef (returned by this factory)
+     * @param klass the TermDefinition.getTermDef (returned by this factory)
      * @param subres (the configuration)
      * @return the generated object
      * @throws PermErrorException if something goes wrong

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/PolicyPostFilter.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/PolicyPostFilter.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/PolicyPostFilter.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/PolicyPostFilter.java
 Mon Sep 17 07:45:08 2007
@@ -35,7 +35,7 @@
      * Filter or replace a record for the given domain
      * 
      * @param currentDomain the domain to retrieve the SPFRecord for
-     * @params record the previous record
+     * @param record the previous record
      * @return the SPFRecord found
      * @throws PermErrorException exception
      * @throws TempErrorException exception

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/DefaultExplanationPolicy.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/DefaultExplanationPolicy.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/DefaultExplanationPolicy.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/DefaultExplanationPolicy.java
 Mon Sep 17 07:45:08 2007
@@ -110,8 +110,9 @@
     private MacroExpand macroExpand;
     
     /**
-     * @param macroExpand 
-     * @param spf
+     * @param log the logger
+     * @param explanation the default explanation
+     * @param macroExpand the MacroExpand service
      */
     public DefaultExplanationPolicy(Logger log, String explanation, 
MacroExpand macroExpand) {
         this.log = log;

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/TrustedForwarderPolicy.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/TrustedForwarderPolicy.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/TrustedForwarderPolicy.java
 (original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/policies/local/TrustedForwarderPolicy.java
 Mon Sep 17 07:45:08 2007
@@ -45,7 +45,7 @@
     private Logger log;
 
     /**
-     * @param spf
+     * @param log the logger
      */
     public TrustedForwarderPolicy(Logger log) {
         this.log = log;

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/GenericModifier.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/GenericModifier.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/GenericModifier.java 
(original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/GenericModifier.java 
Mon Sep 17 07:45:08 2007
@@ -40,10 +40,7 @@
     protected Logger log;
 
     /**
-     * @throws NoneException 
-     * @throws NeutralException 
-     * @see org.apache.james.jspf.terms.Modifier#run(SPFSession)
-     * 
+     * @see 
org.apache.james.jspf.core.SPFChecker#checkSPF(org.apache.james.jspf.core.SPFSession)
      */
     public DNSLookupContinuation checkSPF(SPFSession spfData) throws 
PermErrorException,
             TempErrorException, NeutralException, NoneException {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/IP4Mechanism.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/IP4Mechanism.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/IP4Mechanism.java 
(original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/IP4Mechanism.java 
Mon Sep 17 07:45:08 2007
@@ -41,8 +41,7 @@
     private IPAddr ip = null;
 
     /**
-     * 
-     * @see 
org.apache.james.jspf.core.GenericMechanism#run(org.apache.james.jspf.core.SPFSession)
+     * @see 
org.apache.james.jspf.core.SPFChecker#checkSPF(org.apache.james.jspf.core.SPFSession)
      */
     public DNSLookupContinuation checkSPF(SPFSession spfData) throws 
PermErrorException {
         IPAddr originalIP;
@@ -56,7 +55,7 @@
     }
 
     /**
-     * @see org.apache.james.jspf.terms.GenericMechanism#config(Configuration)
+     * @see 
org.apache.james.jspf.terms.GenericMechanism#config(org.apache.james.jspf.terms.Configuration)
      */
     public synchronized void config(Configuration params) throws 
PermErrorException {
         if (params.groupCount() == 0) {

Modified: 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/UnknownModifier.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/UnknownModifier.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/UnknownModifier.java 
(original)
+++ 
james/jspf/trunk/src/main/java/org/apache/james/jspf/terms/UnknownModifier.java 
Mon Sep 17 07:45:08 2007
@@ -40,7 +40,7 @@
             + SPFTermsRegexps.MACRO_STRING_REGEX + ")";
 
     /**
-     * @see 
org.apache.james.jspf.terms.Modifier#run(org.apache.james.jspf.core.SPFSession)
+     * @see 
org.apache.james.jspf.core.SPFChecker#checkSPF(org.apache.james.jspf.core.SPFSession)
      */
     public DNSLookupContinuation checkSPF(SPFSession spfData) throws 
PermErrorException {
         return null;
@@ -54,7 +54,7 @@
     }
 
     /**
-     * @see 
org.apache.james.jspf.terms.ConfigurationEnabled#config(Configuration)
+     * @see 
org.apache.james.jspf.terms.ConfigurationEnabled#config(org.apache.james.jspf.terms.Configuration)
      */
     public synchronized void config(Configuration params) throws 
PermErrorException {
         if (params.groupCount() >= 2 && params.group(1) != null) {

Modified: 
james/jspf/trunk/src/test/java/org/apache/james/jspf/AbstractYamlTest.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/test/java/org/apache/james/jspf/AbstractYamlTest.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- james/jspf/trunk/src/test/java/org/apache/james/jspf/AbstractYamlTest.java 
(original)
+++ james/jspf/trunk/src/test/java/org/apache/james/jspf/AbstractYamlTest.java 
Mon Sep 17 07:45:08 2007
@@ -320,7 +320,7 @@
     }
 
     /**
-     * @return
+     * @return a Mocked DNSService
      */
     protected DNSService getDNSServiceMockedDNSService() {
         SPFYamlDNSService yamlDNSService = new 
SPFYamlDNSService(data.getZonedata());
@@ -328,7 +328,7 @@
     }
 
     /**
-     * @return
+     * @return the right dnsservice according to what the test specialization 
declares
      */
     protected DNSService getDNSService() {
         switch (getDnsServiceMockStyle()) {
@@ -345,7 +345,7 @@
     }
 
     /**
-     * @return
+     * @return a dns resolver pointing to the local fake server
      */
     protected DNSService getDNSServiceFakeServer() {
         Resolver resolver = null;
@@ -389,7 +389,7 @@
     }
     
     /**
-     * @return
+     * @return a real dns resolver
      */
     protected DNSService getDNSServiceReal() {
         DNSServiceXBillImpl serviceXBillImpl = new DNSServiceXBillImpl(log);

Modified: 
james/jspf/trunk/src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java
URL: 
http://svn.apache.org/viewvc/james/jspf/trunk/src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java?rev=576461&r1=576460&r2=576461&view=diff
==============================================================================
--- 
james/jspf/trunk/src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java
 (original)
+++ 
james/jspf/trunk/src/test/java/org/apache/james/jspf/dnsserver/DNSTestingServer.java
 Mon Sep 17 07:45:08 2007
@@ -452,9 +452,6 @@
         return response.toWire();
     }
 
-    /**
-     * @see org.apache.james.jspf.MessageGenerator#formerrMessage(byte[])
-     */
     public byte[] formerrMessage(byte[] in) {
         Header header;
         try {



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to