Robert Burrell Donkin ha scritto: > On 9/18/07, Robert Burrell Donkin <[EMAIL PROTECTED]> wrote: >> On 9/18/07, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> Currently there are 7 cyclic dependencies between packages. >>> >>> I found this refactoring removes all of them: >>> >>> 1) Create an "jsieve.exception" package to include exception classes >>> from the jsieve main package (jsieve.*Exception) >>> >>> 2) Move MatchTypeTags from test to comparators >>> >>> 3) Move CommandStateManager, ConditionManager and ExecutableCommand from >>> "commands" to the main package. >>> >>> At this point the main package classes (jsieve) could be splitted in 2 >>> different packages because they cover both the high and the low level of >>> the architecture, but this is not required to remove cycles, so I >>> propose to do the 3 steps now, and then see if it worth doing more or not. >>> >>> WDYT? >> sounds good > > unless anyone has any objections, i'll commit something along these > lines in the next few days... > > - robert
+1 I already have this change locally, uncommitted (I applied them for real to be able to run my tool and see if I fixed the cycles). So if you prefer to start from them "applied" and then add further changes just ask. Otherwise I'll checkout your changes once committed! Stefano --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
