Robert Burrell Donkin ha scritto:
On Tue, Apr 29, 2008 at 12:02 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote:
Robert Burrell Donkin ha scritto:

<snip>

 * check pheonix-deployment in server for the test cases of the
mailets moved into here

 The mock stuff (MockMailetConfig, MockMailContext, MockMail,
test.util.Util, maybe something more) is used both by standard-mailet tests
and by james specific mailets.
 What to do?
 A) put the mock stuff in the "base" library in "main" but in a test
package.
 B) put it in the base library test suite and take care of releasing the
test-jar too to be used by james-server and mailet-standard tests.
 C) put it in the standard mailet tests and take care of releasing also the
test jar and put this dependency in james-server.
 D) duplicate the test classes.

 My preferences from best to worst: B, C, A, D.

sounds about right to me

another alternative would be to release another micro-library product
aimed at testing mailets. this would make dependency management more
rational (and maven happier) and the build simpler but would introduce
another micro-library (similar to those in commons).

Maven should not have problem adding dependencies to other test jars.
We already do this in server code:

imap-codec-library tests have a dependency on imap-api test jar:
    <dependency>
      <groupId>org.apache.james</groupId>
      <artifactId>james-server-imap-api</artifactId>
      <type>test-jar</type>
      <scope>test</scope>
    </dependency>


If we call your alternative "E" I revisit my preferences to B, C, E, A, D.

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to