svn commit: r655050 - in /james/jsieve/trunk/src/main/java/org/apache/jsieve: ComparatorManager.java TestManager.java

[bago]

Author: bago
Date: Sat May 10 04:31:03 2008
New Revision: 655050

URL: http://svn.apache.org/viewvc?rev=655050&view=rev
Log:
Made TestManager not directly instantiable (private constructor) like the 
ComparatorManager.
Removed the isSupported method from TestManager and Comparator manager: they 
was not used and duplicate code for PMD

Modified:
    james/jsieve/trunk/src/main/java/org/apache/jsieve/ComparatorManager.java
    james/jsieve/trunk/src/main/java/org/apache/jsieve/TestManager.java

Modified: 
james/jsieve/trunk/src/main/java/org/apache/jsieve/ComparatorManager.java
URL: 
http://svn.apache.org/viewvc/james/jsieve/trunk/src/main/java/org/apache/jsieve/ComparatorManager.java?rev=655050&r1=655049&r2=655050&view=diff
==============================================================================
--- james/jsieve/trunk/src/main/java/org/apache/jsieve/ComparatorManager.java 
(original)
+++ james/jsieve/trunk/src/main/java/org/apache/jsieve/ComparatorManager.java 
Sat May 10 04:31:03 2008
@@ -145,24 +145,6 @@
     }
 
     /**
-     * Method isSupported answers a boolean indicating if a Comparator name is
-     * configured.
-     * 
-     * @param name -
-     *                The Comparator name
-     * @return boolean - True if the Comparator name is configured.
-     */
-    public boolean isSupported(String name) {
-        boolean isSupported = true;
-        try {
-            lookup(name);
-        } catch (LookupException e) {
-            isSupported = false;
-        }
-        return isSupported;
-    }
-
-    /**
      * <p>
      * Method getClassName answers the name of the class to which a Comparator
      * name is mapped.

Modified: james/jsieve/trunk/src/main/java/org/apache/jsieve/TestManager.java
URL: 
http://svn.apache.org/viewvc/james/jsieve/trunk/src/main/java/org/apache/jsieve/TestManager.java?rev=655050&r1=655049&r2=655050&view=diff
==============================================================================
--- james/jsieve/trunk/src/main/java/org/apache/jsieve/TestManager.java 
(original)
+++ james/jsieve/trunk/src/main/java/org/apache/jsieve/TestManager.java Sat May 
10 04:31:03 2008
@@ -35,9 +35,9 @@
     static private TestManager fieldInstance;
 
     /**
-     * Constructor for TestManager.
+     * TestManager is instanciated with getInstance
      */
-    public TestManager() {
+    private TestManager() {
         super();
     }
 
@@ -145,24 +145,6 @@
     }
 
     /**
-     * Method isSupported answers a boolean indicating if a Test name is
-     * configured.
-     * 
-     * @param name -
-     *                The Test name
-     * @return boolean - True if the Test name is configured.
-     */
-    public boolean isSupported(String name) {
-        boolean isSupported = true;
-        try {
-            lookup(name);
-        } catch (LookupException e) {
-            isSupported = false;
-        }
-        return isSupported;
-    }
-
-    /**
      * <p>
      * Method getClassName answers the name of the class to which a Test name 
is
      * mapped.



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]