Robert Burrell Donkin ha scritto:
On Mon, May 12, 2008 at 10:04 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote:
Hi all,
I see jSieve include a static class used to lookup the common logger:
http://svn.apache.org/repos/asf/james/jsieve/trunk/src/main/java/org/apache/jsieve/Logger.java
This is a singleton and return a commons-logging Log object.
Every class uses "Logger.getLog()" to get a common-logging logger instance
so every class already depends on commons-logging.
What are the advantages of this class over the direct use of
commons.logging LogFactory ?
it allows the shared log instance can be set
I'm not a commons-logging expert, but can't this be already done by
using commons-logging specific implementation configurations even if
each class directly calls the LogFactory.getLog() method?
all the singletons should really be replaced by IoC but that would
require some effort and entail some risk
+1
Should we add a JIRA issue for the next releases, so we are better aware
of this?
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
