On Mon, May 12, 2008 at 8:05 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: > > > > > On Mon, May 12, 2008 at 10:55 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > > > > > > > I think synchronization on James.class is an error. > > > The getId has been copied there from JAMES. But either we use the same > > > counter (and not 2 different counters) or we simply have to make the > > > counter++ synchronized on the ToMultiRepository instance itself and use > a > > > different naming scheme to prevent from creating duplicated names. > > > I just committed a fix (r655453) for this, please review it. > > > > > > > i've committed a variation that uses AtomicLong from backport concurrent > utils > > > > Maybe introducing a new dependency for this (backport-util-concurrent) is > too much,
backport-util-concurrent is already a dependency > but OTOH maybe we could move from concurrent to > backport-util-concurrent for our IMAP/mailboxmanager code. means a dependency bump for the whole of JAMES > The main problem with this move is that I fear there are transitive > dependencies to oswego concurrent library. really? > opinions? maybe i'll just commit another variation - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
