Robert Burrell Donkin ha scritto:
On Thu, Jul 10, 2008 at 5:54 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote:

<sniP>

I noticed we have some unused class:
- util.StringArrayMap
- util.PartialInputStream
- util.PositionInputStream
- EOLConvertingInputStream
- CloseShieldInputStream
what should we do? (delete? deprecate?)

i'd like to keep EOLConvertingInputStream around but i think the rest
can be deleted

ok!

i've been wondering whefher the interfaces i factored from
MaximalBodyDescriptor are worthwhile:

* RFC1864ContentMD5Descriptor.java
* RFC2045MimeDescriptor.java
* RFC2183ContentDispositionDescriptor.java
* RFC2557ContentLocationDescriptor.java
* RFC3066ContentLanguageDescriptor.java

they serve to indicate the RFCs implemented but i think now they serve
no substantive purpose. perhaps they should just be deleted.

opinions?

I'm not sure what patterns we should push to better support evolution.

Having the interfaces let users using (obj instanceof RFCxxxxDescriptor) ((RFCxxxxDescriptor) obj).rfcSpecificMethod and I would prefer this instead of promoting the use of "MaximalBodyDescriptor".

E.g: I would like to be able to "configure" mime4j to support RFC2045 and RFC3066 while I may not care of the others. Is this something that could happen in a future mime4j release? In this case let's keep the interfaces, otherwise we just need comments on the methods to tell what RFC they are about.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to