InputBuffer to extend FilterInputStream
---------------------------------------
Key: MIME4J-50
URL: https://issues.apache.org/jira/browse/MIME4J-50
Project: Mime4j
Issue Type: Improvement
Affects Versions: 0.3
Reporter: Stefano Bagnara
Fix For: 0.4
I create this issue to attach a patch (not sure our mailing list support this).
I was looking at InputBuffer and I noticed how much it looks like a
FilterInputStream class but it doesn't expose the InputStream "interface" (ok,
it is not an interface, but an abstract class).
Am I missing something or extending InputStreamFilter does not add complexity
to the class while increasing its flexibility/reusability?
I gave this a go by making BufferingInputStream an extension of
FilterInputStream and by letting InputBuffer extending the "new"
BufferingInputStream.
This also gave me the opportunity to simplify some code aroud avoiding multiple
wrapping of the InputBuffer.
After this patch all of the tests still pass.
I did not rename "InputBuffer" with this patch, but maybe it should include
Buffered, InputStream and Filter words to better autodocumentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
