[ 
https://issues.apache.org/jira/browse/MIME4J-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616154#action_12616154
 ] 

Robert Burrell Donkin commented on MIME4J-67:
---------------------------------------------

Stefano

Your proposals are more verbose and less performant than the current approach 
but I really don't care enough about the DOM API to continue this pointless 
arguing. Fixing the current code would be simple enough but if you want to rip 
out and replace the current implementation I'm not going to waste my time doing 
that. 

You've made it quite clear that you don't like the current approach and you 
would prefer a less performant one copied from elsewhere. Fine. Providing that 
you don't propose changes in the lower level pull parser which really belong in 
the DOM API layer then I'm happy for you to dive in an fix stuff in the DOM API 
without wasting time with the amount of ceremony. 

Robert

> Base64Encoder fails to encode streams longer than its buffer size (1024)
> ------------------------------------------------------------------------
>
>                 Key: MIME4J-67
>                 URL: https://issues.apache.org/jira/browse/MIME4J-67
>             Project: Mime4j
>          Issue Type: Bug
>    Affects Versions: 0.4
>            Reporter: Stefano Bagnara
>             Fix For: 0.4
>
>
> When encoding streams longer than 1024 bytes the encoder simply concatenate 
> the base64 version of each 1024 chunk and this is wrong. Base64 streams are 
> only concatenable when the original text length was a multiple of 3. 
> Supporting buffer chunks encoding require keeping the last 1-2 bytes in a 
> buffer and eventually convert them to base64 ending sequences only when the 
> stream is closed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to