Robert Burrell Donkin ha scritto:
i have a few header nits but nothing that should stop a release

What files?

We exclude from rat check this files:
<exclude>src/test/resources/testmsgs/*</exclude>
<!-- 3rd party descriptors distributed via maven repositories
                 and included "as is" -->
<exclude>stage/commons-io/poms/commons-io-1.2.pom</exclude>
<exclude>stage/commons-logging/poms/commons-logging-1.1.pom</exclude>
<exclude>stage/org.apache.james/xmls/james-parent-1.1-site.xml</exclude>
<exclude>stage/org.apache.james/xmls/james-parent-1.1-site_en.xml</exclude>
<exclude>stage/org.apache.james/xmls/james-project-1.2-site.xml</exclude>
<exclude>stage/org.apache.james/xmls/james-project-1.2-site_en.xml</exclude>
<exclude>release.properties</exclude>

for testmsgs we don't have a way to add comments without altering the content.

The xml and poms, instead are ASF released content and they have been copied as is instead of altering their content to add the ASF header. As you know the issue is that maven remove the license from that files during the release process, it should be fixed in latest maven+latest plugins but I never released since I saw the JIRA for this resolved.

About BUILDING.txt and RELEASE_NOTES.txt I'm not sure why rat didn't check them for headers (maybe you better know this).

Thank you,
Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to