[
https://issues.apache.org/jira/browse/JSIEVE-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627296#action_12627296
]
Robert Burrell Donkin commented on JSIEVE-16:
---------------------------------------------
The [pseudo-]singletons can be categorised into:
* Entry point:
* SieveFactory
* Configuration:
* ConfigurationManager
* ComparatorManager
* TestManager
* CommandManager
* Logger
* Magic context:
* ConditionManager
* CommandStateManager
Should be possible to factor magic context into a Context which is passed
though on execution
Should be possible to separate concerns about configuration from execution by
creating interfaces and a default builder
> Singletons -> IoC
> -----------------
>
> Key: JSIEVE-16
> URL: https://issues.apache.org/jira/browse/JSIEVE-16
> Project: jSieve
> Issue Type: Task
> Reporter: Robert Burrell Donkin
> Fix For: 1.0
>
>
> The current code uses per-thread pseudo-singletons. This requires complex
> and fragile sychronisation code.
> Factor out interfaces and inject dependencies. Any synchronisation required
> should be provided by the user of library.
> See
> http://mail-archives.apache.org/mod_mbox/james-server-dev/200708.mbox/[EMAIL
> PROTECTED] thread for more details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
