[
https://issues.apache.org/jira/browse/MIME4J-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633228#action_12633228
]
Stefano Bagnara commented on MIME4J-73:
---------------------------------------
Some of them declare IOException, some of them MimeException, some other none.
I guess all of them should throw the same stuff: should all of them throw
MimeException (wrapping IOException if needed) or should all of them throw both
exceptions? (This also depend on how we'll deal with MIME4J-77, but in the mean
time we need a working temporary solution). ATM throwing IOException would
suffice as MimeException is an IOException.
Maybe the simpler solution is to add "throws IOException" to every public
method.
I tested this locally and this does not require any other change to mime4j,
maybe this can be done in 0.5 before the vote with no further review, if others
agree with this approach.
> IllegalArgumentException in Message constructor when parsing erroneous message
> ------------------------------------------------------------------------------
>
> Key: MIME4J-73
> URL: https://issues.apache.org/jira/browse/MIME4J-73
> Project: JAMES Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Markus Wiederkehr
> Fix For: 0.5
>
> Attachments: mime4j-message-2.patch, mime4j-message.patch
>
>
> The constructor of Message(InputStream) uses its inner class MessageBuilder
> to parse the input stream and create the object. The method
> MessageBuilder.field(String) calls Field.parse(String) to parse header
> fields. This method throws an IllegalArgumentException on parse errors.
> Clearly the Message constructor should throw a MimeException instead of an
> IllegalArgumentException if an invalid header field is encountered (or else
> it should simply ignore the field). So either Field.parse(String) should
> throw a MimeException or MessageBuilder.field(String) should catch and
> convert it.
> And by the way, could you make MessageBuilder public so it can be extended if
> a slightly different behavior is desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
