[ 
https://issues.apache.org/jira/browse/JAMES-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634087#action_12634087
 ] 

Stefano Bagnara commented on JAMES-874:
---------------------------------------

Hi Ajay,

I was about reviewing your code. At a first glance you did a great job. I think 
it worth applying the same javadoc/comment formatting fixes to RemoteDelivery 
first and then extract common parts.

I'm not sure how we are supposed to deal with the @author and Copyright 
statement you added to the file. Our sourcecode usually don't include @author 
tags (per Apache policy) and we use our default Apache license header:

<pre>
/****************************************************************
 * Licensed to the Apache Software Foundation (ASF) under one   *
 * or more contributor license agreements.  See the NOTICE file *
 * distributed with this work for additional information        *
 * regarding copyright ownership.  The ASF licenses this file   *
 * to you under the Apache License, Version 2.0 (the            *
 * "License"); you may not use this file except in compliance   *
 * with the License.  You may obtain a copy of the License at   *
 *                                                              *
 *   http://www.apache.org/licenses/LICENSE-2.0                 *
 *                                                              *
 * Unless required by applicable law or agreed to in writing,   *
 * software distributed under the License is distributed on an  *
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
 * KIND, either express or implied.  See the License for the    *
 * specific language governing permissions and limitations      *
 * under the License.                                           *
 ****************************************************************/
</pre>

Would you mind submitting the same file without copyright/author statements so 
I can go directly to the code without dealing with our legal/policy teams?

Otherwise this JIRA issue is already very good as an archetype for people that 
will need something similar.

> Retry Mailet
> ------------
>
>                 Key: JAMES-874
>                 URL: https://issues.apache.org/jira/browse/JAMES-874
>             Project: JAMES Server
>          Issue Type: New Feature
>          Components: James Core
>    Affects Versions: 2.3.1
>            Reporter: Ajay Chitre
>         Attachments: RetryMailet.java
>
>
> Recently, I sent an email to the James User list to find out if 'Retrying' 
> functionality exists in James.  It appears that it doesn't.  One reader 
> indicated that this has been requested quite a few times, so if we develop 
> it, we should consider sending it for review.  Stefano (Bagnara) recommended 
> using RemoteDelivery as a starting point for this feature.  I have attached a 
> class that implements this functionality.  Please review the attached code, 
> and provide feedback.
> If you think this will be useful to other users, please feel free to include 
> it in James code base.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to