[ https://issues.apache.org/jira/browse/MIME4J-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634126#action_12634126 ]
Markus Wiederkehr commented on MIME4J-79: ----------------------------------------- Adding "closed = true" would not have been necessary because this branch only gets executed if len < 0. len < 0 would normally be an illegal argument for this method and should be punished by throwing an IllegalArgumentException. In case of this implementation it is used by close() to indicate EOF. And close() already takes care of setting closed to true in its finally block. > Message.writeTo() prematurely closes output stream if transfer encoding is > BASE64 > --------------------------------------------------------------------------------- > > Key: MIME4J-79 > URL: https://issues.apache.org/jira/browse/MIME4J-79 > Project: JAMES Mime4j > Issue Type: Bug > Affects Versions: 0.5 > Reporter: Markus Wiederkehr > Assignee: Stefano Bagnara > Priority: Blocker > Fix For: 0.5 > > Attachments: Base64BugDemo.java, mime4j-base64.patch, > mime4j-close-codec-ioex.patch, mime4j-close-codec.patch > > > Entity.writeTo(OutputStream out, int mode) wraps the output stream in a > Base64OutputStream if the transfer encoding is BASE64. Later the wrapper > stream gets closed and (despite of a comment that says otherwise) the inner > stream gets closed, too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]