[
https://issues.apache.org/jira/browse/MIME4J-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638370#action_12638370
]
Stefano Bagnara commented on MIME4J-72:
---------------------------------------
@Markus: About your 2nd point (The visitor can now handle Message, Multipart,
BodyPart and Body )
This sounds weaker than Oleg's one.
E.g: Multipart is not defined by the basic MIME specification. In rfc1521 we
have "message", "body part", "entity" and "body" defined. It also define that
"message" and "body part" are "entities", so once we defined "entity" and
"body" we can visit anything. Everything else is just a specialization of
entity or body (or both).
Adding anything beyond what is defined in rfc1521 to a generic visitor make it
no more extensible or tied to specific extensions.
AFAIUI "Oleg's Visitor" already allow you to traverse the whole structure
(multipart included), what feature are you pursuing with your changes?
> Provide a means to dispose a Message
> ------------------------------------
>
> Key: MIME4J-72
> URL: https://issues.apache.org/jira/browse/MIME4J-72
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Robert Burrell Donkin
> Attachments: entityvisitor.patch, mime4j-disposable.patch,
> mime4j-dispose-finalize.patch, mime4j-dispose-no-clutter.patch,
> mime4j-dispose-visitor.patch
>
>
> Currently an org.apache.james.mime4j.message.Message uses temporary files to
> store text and binary attachments of the message. Unfortunately a Message
> cannot be disposed of explicitly. Even when it eventually gets garbage
> collected the temp files continue to exist until the VM exits.
> If the VM runs for a long time and a lot of e-mails get processed this can
> become a major problem.
> For this reason I think that class Entity and interface Body should both have
> a method to dispose of the object. Multipart should dispatch a dispose-call
> to its list of body parts. A BodyPart should dispose of its body and concrete
> Body implementation such as TempFileTextBody should ultimately invoke
> delete() on the backing TempFile.
> Last but not least SimpleTempStorage$SimpleTempFile should not silently
> ignore delete-calls.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
