Robert Burrell Donkin ha scritto: > On Wed, Nov 12, 2008 at 5:27 PM, Robert Burrell Donkin > <[EMAIL PROTECTED]> wrote: >> On Wed, Nov 12, 2008 at 9:23 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> Robert Burrell Donkin ha scritto: >>>> On Sun, Nov 9, 2008 at 9:53 PM, Robert Burrell Donkin >>>> <[EMAIL PROTECTED]> wrote: >>>>> On Sun, Nov 9, 2008 at 5:32 PM, Robert Burrell Donkin >>>>> <[EMAIL PROTECTED]> wrote: >>>>>> On Sun, Nov 9, 2008 at 4:09 PM, Stefano Bagnara <[EMAIL PROTECTED]> >>>>>> wrote: >>>>>>> Robert Burrell Donkin ha scritto: >>>>> <snip> >>>>> >>>>>>>> i think that it should be possible to move the sieve mailet (and the >>>>>>>> dependent mdn micro-library) from server into the jsieve project. >>>>>>>> AFAICT samples contains only a mailet example so i think this can be >>>>>>>> removed. unless anyone can see anything wrong with this approach, i'll >>>>>>>> probably just dive in sometime soonish... >>>>>>> Sounds good! >>>>>> done >>>>> not quite: i missed the dependency between the >>>>> org.apache.james.util.mail.mdn and >>>>> org.apache.james.util.mail.MimeMultipartReport. this is used by other >>>>> mailets so it's not really possible to move it out into sieve. >>>>> >>>>> i suppose that one possibility might be to move some or all of the >>>>> stuff in javamail-util into mailet-base >>>> the stuff currently in javamail utils is packaged >>>> org.apache.james.util but is mostly used by mailets and is (mostly) >>>> not strongly coupled to the rest of the server. moving most of the >>>> contents to mailet-base (and the rest to mailet-function module in the >>>> server) would allow this module to eliminated and allow more mailets >>>> (including sieve) to be factored out of the server code base. >>>> >>>> any objections? >>> Most code can be moved but SpamAssassinInvoker.java seems a bit off >>> topic in mailet-base. >> yes : i think that belongs with the spam assassin mailet > > the class is shared with the spam assassin fail fast plugin so it'll > have to stay where it is for now
I knew it is used by both a mailet and a fastfail plugin, and that's why it was in the javamail-util package. But mailet-base seems a wrong place for it to me. BTW nothing is definitive, so we can move where it gives less problems now, then we'll think to better places in a future cycle. Stefano --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
