On Sun, Dec 14, 2008 at 8:35 PM, Markus Wiederkehr
<markus.wiederk...@gmail.com> wrote:
> Sorry about my last comment on MIME4J-66. I did not realize that it is
> about Base64Encoder, not Base64OutputStream..
>
> But is Base64Encoder really necessary? I mean
> CodecUtil.encodeBase64(InputStream, OutputStream) could also be
> implemented as:
>        Base64OutputStream b64Out = new Base64OutputStream(out);
>        copy(in, b64Out);
>        b64Out.close();
>
> Why maintain two versions?

copy uses more memory and is slower

> I also noticed that CodecUtil.encodeBase64 is not called anywhere in
> Mime4j. Could we remove it entirely?
>
> The same arguments apply to QuotedPrintableEncoder and
> CodecUtil.encodeQuotedPrintable..

these methods are more performant but less well tested. take them out
if you like.

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to