On Tue, Apr 21, 2009 at 5:15 PM, Stefano Bagnara <[email protected]> wrote: > Markus Wiederkehr ha scritto: >> Should I use the same "new StringBuffer(256).append().." mechanism >> found everywhere else in RemoteDelivery? I guess it's only about the >> initial size of 256 characters? > > I'm a fan of simple string concatenation, because I believe in javac ;-)
this is a little controversial on JDK1.5, string concatination is quicker than string buffer so better to use StringBuilder on trunk and StringBuffer on 2.x >> And where do I have to commit the patch? james/server/branches/v2.3/ >> and james/server/trunk/mailets-function/? > > trunk! > And maybe this should also be backported to v2.3, +1 to backport it as > it is a "major" bug (leading to multiple deliveries). +1 >> Or does someone else want to commit? > > Please do it. +1 - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
