On Wed, May 20, 2009 at 1:20 PM, Stefano Bagnara <[email protected]> wrote: > Robert Burrell Donkin ha scritto: >> opinions? >> >> On Wed, May 20, 2009 at 12:21 PM, Robert Burrell Donkin (JIRA) >> <[email protected]> wrote: >>> Robert Burrell Donkin commented on JAMES-907: >>> --------------------------------------------- >>> >>> Of those remaining, there are: >>> >>> Notices >>> v2.3/lib/cornerstone-datasources-impl-2.1-patched.README >>> v2.3/lib/cornerstone-sockets-impl-2.1-patched.README > > Created by me. Feel free to add an header (I didn't know a README > required a license header at that time). > >>> v2.3/lib/readme.xml > > Don't know what it is. > >>> v2.3/tools/lib/LICENSE.xdoclet.txt > > This is a LICENSE, licenses do not need an header.
i'm happy that all the above are notices which don't really require a header >>> Pheonix: >>> v2.3/phoenix-bin/apps/dummy.txt >>> v2.3/phoenix-bin/bin/derby.properties >>> v2.3/phoenix-bin/bin/phoenix.sh >>> v2.3/phoenix-bin/bin/run.bat >>> v2.3/phoenix-bin/bin/run.sh >>> v2.3/phoenix-bin/conf/kernel.xml >>> v2.3/phoenix-bin/conf/phoenix-service.xml >>> v2.3/phoenix-bin/conf/wrapper.conf > > They are files from the phoenix distribution. We tried to change as less > as possible in that folder. i'm happy with preserving them as is >>> Manifests etc: >>> v2.3/src/Manifest-mailet.mf >>> v2.3/src/Manifest.mf >>> v2.3/src/meta-inf/mailcap > > Files created by james people. An header can be added. i consider these as effectively binaries since comments are a PITA >>> Stylesheet >>> v2.3/src/site/xdoc/stylesheet.css > > Probably created by me. i'll add a header >>> Test Files: >>> v2.3/src/test/org/apache/james/dnsserver/brandilyncollins-com.zone >>> v2.3/src/test/org/apache/james/dnsserver/pippo-com.zone >>> v2.3/src/test/org/apache/james/dnsserver/test-zone-com.zone > > Created by me. Maybe the test tool reading that file does not support > comments. in that case, IMHO they don't need a header >>> Tools: >>> v2.3/tools/bin/ant >>> v2.3/tools/bin/ant.bat >>> v2.3/tools/bin/antRun >>> v2.3/tools/bin/antRun.bat >>> v2.3/tools/bin/antRun.pl >>> v2.3/tools/bin/complete-ant-cmd.pl >>> v2.3/tools/bin/lcp.bat >>> v2.3/tools/bin/runant.pl >>> v2.3/tools/bin/runant.py >>> v2.3/tools/etc/changelog.xsl >>> v2.3/tools/etc/checkstyle-frames.xsl >>> v2.3/tools/etc/coverage-frames.xsl >>> v2.3/tools/etc/jdepend-frames.xsl >>> v2.3/tools/etc/jdepend.xsl >>> v2.3/tools/etc/junit-frames.xsl >>> v2.3/tools/etc/junit-noframes.xsl >>> v2.3/tools/etc/log.xsl >>> v2.3/tools/etc/maudit-frames.xsl >>> v2.3/tools/etc/mmetrics-frames.xsl >>> v2.3/tools/etc/tagdiff.xsl > > Don't know anything about the tools folder. I always tied to stay away > from it. i'll investigate - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
