On Sun, Jun 14, 2009 at 8:17 PM, Robert Burrell
Donkin<robertburrelldon...@gmail.com> wrote:
> On Fri, Jun 12, 2009 at 10:18 PM, Markus
> Wiederkehr<markus.wiederk...@gmail.com> wrote:
>> One thing I have noticed is that MPT is misspelled as MTP in a lot of 
>> places..
>>
>> find -name .svn -prune -o -print0 | xargs -0 grep -i [^s]mtp
>> .. returns 108 lines in mpt trunk.
>
> not good :-/
>
>> Aside from that I have downloaded the artifacts and run a simple mpt
>> script against localhost:25 using the command line app and an ant
>> script. I ran into the problem that brackets in the server response
>> have to be escaped because of regex but that's not MPTs fault of
>> course.
>
> i do find this a little annoying too. suggestions welcomed :-)

Maybe the server string should not be interpreted as regular
expression unless some kind of flag or marker gets set explicitly.
E.g. prefixes C:, S: and R: for client, server and server regex
respectively..

>> I trust that Stefano has checked the license/notice files thoroughly.
>> Also I've browsed through the source code but I did not spend very
>> much time on that..
>>
>> Would that suffice for me to cast a vote?
>
> release votes are a personal decision: it's up to you whether you
> think the defects are serious enough

Yes of course, I just wanted to make sure that my review meats at
least some minimal standard. Especially since I am not really
affiliated to the project.

Markus

> i'm happy to fix these issues and restart the release candidate
> process again, or just to ship with known defects and then look to cut
> a fix release (this is a 3.x dependency which provides the motivation
> for this release)
>
> - robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
> For additional commands, e-mail: server-dev-h...@james.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to