Good point. What about adding MailAdapter.setContext(SieveContext)? That way you can pass the context to the MailAdapter implementation in one place, instead of having to pass it to every method.
----- "Robert Burrell Donkin" <[email protected]> wrote: > On Thu, Jul 2, 2009 at 5:51 PM, Boris Burtin<[email protected]> > wrote: > > Either that or add ActionKeep.isImplicit(). I guess it depends on > the general usefulness of SieveContext. If it only makes sense during > parsing, then there's no need to pass it to executeActions(). > > for libraries, it's usually easier to pass a context (as a parameter > object) so that new data can be added without breaking interface > compatability. but whether SieveContext is the right context is open. > > opinions? > > > I'll go ahead and hack my version of jSieve 0.3 to add > ActionKeep.isImplicit(), and set the state in Keep.executeBasic(). If > you have a better workaround, please let me know! I filed JSIEVE-56 > for this issue. > > cool > > - robert > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
