On Wed, Aug 19, 2009 at 7:52 PM, Robert Burrell Donkin<[email protected]> wrote: > On Wed, Aug 19, 2009 at 5:24 PM, Norman Maurer<[email protected]> wrote: >> 2009/8/19 Robert Burrell Donkin <[email protected]>: >>> On Wed, Aug 19, 2009 at 4:56 PM, Norman Maurer<[email protected]> wrote: >>>> 2009/8/19 Robert Burrell Donkin <[email protected]>: >>>>> On Wed, Aug 19, 2009 at 4:06 PM, Norman Maurer<[email protected]> wrote: >>>>>> Comments inside.. >>>>>> >>>>>> >>>>>> 2009/8/19 Robert Burrell Donkin <[email protected]>: >>>>>>> On Wed, Aug 19, 2009 at 9:35 AM, Norman Maurer<[email protected]> wrote: >>>>>>>> Hi Robert, >>>>>>>> >>>>>>>> comments inside... >>>>>>>> >>>>>>>> 2009/8/19 Robert Burrell Donkin <[email protected]>: >>>>>>>>> Loader Service >>>>>>>>> ------------------ >>>>>>>>> >>>>>>>>> create loading services (LoaderService interface?) for classes. this >>>>>>>>> can be used to replace the classloading each uses ATM. API probably >>>>>>>>> something like: >>>>>>>>> >>>>>>>>> <T> load(class<T> type) >>>>>>>>> >>>>>>>>> once this is done, we switch the implementation to use guice primed >>>>>>>>> with a module dynamically assembled by PhoenixLoader. would need to >>>>>>>>> support JSR250 annotation. >>>>>>>>> >>>>>>>> >>>>>>>> +1 >>>>>>> >>>>>>> anyone want to take a look at this? >>>>>>> >>>>>> >>>>>> Yeah I would like to tackle this. >>>>> >>>>> cool >>>>> >>>>> i've been looking at the mailet side of things today >>>>> >>>>>> Just to understand your vision a bit >>>>>> I want to make sure I understood correct: >>>>>> >>>>>> 1) Add a new LoaderService which will get injected via Service >>>>>> livecycle into the "core" services, and will get used to create new >>>>>> instaces via Injector.getInstance(..) >>>>> >>>>> easier just to use the JSR250 annotation support that's already in >>>>> there for setter based service injection >>>> >>>> Sorry not understand :( >>> >>> for services loaded by phoenix, PhoenixLoader already supports setter >>> injection and injection-aware lifecycles via JSR250 annotations >>> >>> - robert >>> >> >> Ah got it.. > > i've been playing around trying to reuse the same interface for > service injection (by name) and component injection (by type name). my > thinking was that it'd be better to centralise the class loading foo. > i'm not going to be able to make this play with the spring deployment > and the PhoenixLoader changes turned out to be pretty ugly. so, i > think we need to go with plan A and an LoaderService interface with > API > > <T> load(class<T> type) > > i think it'd be best if i go ahead and add an example of the wiring > into the mailet loaders. once this is in, the tasks split down into > wiring the handlers and guicing PhoenixLoader, which should be > more-or-less independent.
committed hopefully the idea will be a bit clearer now - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
