I think removing them from the Session is a good idea, but I would prefer to inject them directly ( if they are needed). So just keep the Session as simple as possible.
Bye, Norman 2009/8/22 Robert Burrell Donkin <[email protected]>: > On Wed, Aug 19, 2009 at 9:59 PM, Robert Burrell > Donkin<[email protected]> wrote: >> On Wed, Aug 19, 2009 at 4:07 PM, Norman Maurer<[email protected]> wrote: >>> I don't have a good Idea howto get this done. Maybe with some help of you ;) >> >> unless anyone else jumps in, i'll focus on this tomorrow > > the pattern ATM is to expose a configuration object through the > session. this typically contains a mix of services and configuration. > james services are typically broad APIs. > > for example, SMTPHandlerConfigurationData is exposed by SMTPSession. > as well as configuration data such as max message size, it also has > getters for UserRepository and MailServer services. > > i think it would be better if handlers were not directly coupled to > services exposed through the session. i'd like to add explicit methods > to session and remove the getter. i think that this would aid > understanding and simplify the code. > > any objections? > > - robert > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
