+1, this makes sense. I would even like to eliminate the whole "extends AbstractLogEnabled" stuff. I think there is no need to extend a class just to be able to log..
Bye, Norman 2009/9/5 Robert Burrell Donkin <[email protected]>: > ATM the logger in smtpserver is service sensitive but not context > sensitive. in other words, avalon is used to ensure that all logs are > directed to an output based not on class but on the fact that the > instance is used within the smtp service. IMAP uses context sensitive > logging. logs are not set on each instances but are passed in for each > important method invocation typically using the session. this allows > messages to be prefixed with information about the handler and session > context for the call. i've found this very useful. > > i'd like to replace support for the avalon logger in the handlers by > adding a getter for a JCL[1] log to SMTPSession. a prefixing > JCL->Avalon adaptor would allow contextual information to be added to > messages before they are written to the underlying avalon logging > system. > > opinions? > objections? > > - robert > > [1] http://commons.apache.org/logging/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
