Hi, I wonder if it would make sense to move the ConfigurationWrapping to an extra service (because we could reuse it for other components too) and only inject an "Subnodeconfiguration" into the handler. This should work with using configurationAt() method of commons configuration. IMHO a handler should only need the part of the configuration which belongs to it...
Thoughts ? Bye, Norman 2009/9/8 Norman Maurer <[email protected]>: > Hi all, > > please review the just commited first draft of using Commons > configuration to configure handler / hooks. Its not complete yet but I > think you can get an idea about the idea.. > > Thx, > Norman > > 2009/9/8 Norman Maurer <[email protected]>: >> Hi Stefano, >> >> thx for the response. IoC for Logging is the way to go, you are right. >> >> Hope you enjoyed your holiday ;) >> >> Bye, >> Norman >> >> >> 2009/9/8 Stefano Bagnara <[email protected]>: >>> 2009/9/7 Norman Maurer <[email protected]>: >>>> Hi all, >>>> >>>> I saw this "http://issues.apache.org/jira/browse/JAMES-495";. In the >>>> comments Stefano said that such a wrapper already exists. Anyone has >>>> some pointer. Just to prevent to redo all the work ;) >>> >>> Ehi, this was from more than 3 years ago... I really don't remember >>> anything anymore! >>> I just tried a web search with no success. >>> >>> About the generic issue: I prefer injected logger instead of the more >>> widely adopted Log.getLogger way. BTW, as long as you work on new >>> features and evolving james I'm fine with any choice. I just don't >>> understand why IoC colonized the whole java world but logging. >>> >>> Stefano >>> >>> PS: I'm happy to see that some new work happen in trunk. Maybe I >>> should go on holiday much more often. >>> >>>> Bye, >>>> Norman >>>> >>>> 2009/9/7 Norman Maurer <[email protected]>: >>>>> Hi Robert, >>>>> >>>>> I just lookin at implementing the Avalon Commons Configuration >>>>> adapter. I think adding a Log parameter doesn't make so much sense. It >>>>> just seems to be not logical. Why not just inject the Logger and use >>>>> the injected ? >>>>> >>>>> Bye, >>>>> Norman >>>>> >>>>> 2009/9/7 Robert Burrell Donkin <[email protected]>: >>>>>> the other place that handlers log is when processing the >>>>>> configuration. i agree that it's best to replace the avalon >>>>>> configuration mechanism but i was wondering whether it would be >>>>>> worthwhile introducing a ConfigurableHandler interface similar to the >>>>>> avalon Configurable but with an additional Log parameter as a first >>>>>> step.. >>>>>> >>>>>> opinions? >>>>>> >>>>>> - robert >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
