Author: norman
Date: Wed Sep 30 17:02:45 2009
New Revision: 820345
URL: http://svn.apache.org/viewvc?rev=820345&view=rev
Log:
Add PIPELINING to Capa
Modified:
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/CapaCmdHandler.java
james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3ServerTest.java
Modified:
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/CapaCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/CapaCmdHandler.java?rev=820345&r1=820344&r2=820345&view=diff
==============================================================================
---
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/CapaCmdHandler.java
(original)
+++
james/server/trunk/pop3server-function/src/main/java/org/apache/james/pop3server/CapaCmdHandler.java
Wed Sep 30 17:02:45 2009
@@ -23,7 +23,7 @@
import java.util.ArrayList;
import java.util.List;
-public class CapaCmdHandler implements CommandHandler{
+public class CapaCmdHandler implements CommandHandler, CapaCapability{
public final static String COMMAND_NAME = "CAPA";
private List<CapaCapability> caps = new ArrayList<CapaCapability>();
@@ -41,15 +41,17 @@
*/
public void onCommand(POP3Session session) {
session.writeResponse(POP3Handler.OK_RESPONSE+ " Capability
list follows");
+
for (int i = 0; i < caps.size(); i++) {
- List<String> cList =
caps.get(i).getImplementedCapabilities(session);
+ List<String> cList =
caps.get(i).getImplementedCapabilities(session);
for (int a = 0; a < cList.size(); a++) {
session.writeResponse(cList.get(a));
}
}
session.writeResponse(".");
}
+
/**
* Wire the handler
@@ -60,4 +62,14 @@
caps.add(capHandler);
}
+ /**
+ * @see
org.apache.james.pop3server.CapaCapability#getImplementedCapabilities(org.apache.james.pop3server.POP3Session)
+ */
+ public List<String> getImplementedCapabilities(POP3Session session) {
+ List<String> cList = new ArrayList<String>();
+ // PIPELINING is supported anyway
+ cList.add("PIPELINING");
+ return cList;
+ }
+
}
Modified:
james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3ServerTest.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3ServerTest.java?rev=820345&r1=820344&r2=820345&view=diff
==============================================================================
---
james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3ServerTest.java
(original)
+++
james/server/trunk/pop3server-function/src/test/java/org/apache/james/pop3server/POP3ServerTest.java
Wed Sep 30 17:02:45 2009
@@ -488,7 +488,8 @@
List<String> replies =
Arrays.asList(m_pop3Protocol.getReplyStrings());
assertTrue("contains USER", replies.contains("USER"));
-
+ assertTrue("contains PIPELINING", replies.contains("PIPELINING"));
+
m_pop3Protocol.login("foo", pass);
assertEquals(POP3Reply.OK, m_pop3Protocol.sendCommand("CAPA"));
@@ -498,6 +499,7 @@
assertTrue("contains USER", replies.contains("USER"));
assertTrue("contains UIDL", replies.contains("UIDL"));
assertTrue("contains TOP", replies.contains("TOP"));
+ assertTrue("contains PIPELINING", replies.contains("PIPELINING"));
ContainerUtil.dispose(mockMailRepository);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
