[
https://issues.apache.org/jira/browse/JDKIM-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908969#action_12908969
]
Stefano Bagnara commented on JDKIM-20:
--------------------------------------
I added a catch for the IllegalArgumentException by throwing a PermError with a
meaningful error. Added a sample synthetical message to the test suite (the
issue was with unencoded "=" in the value of "i=" parameter).
Also I verified an IllegalStateException while parsing the remote Public Key. I
added a similar try/catch to the signatureVerify method, as you suggested.
> jdkim will throw unexpected exceptions
> --------------------------------------
>
> Key: JDKIM-20
> URL: https://issues.apache.org/jira/browse/JDKIM-20
> Project: JAMES jDKIM
> Issue Type: Bug
> Components: library
> Affects Versions: 0.2, 1.0
> Environment: java version "1.6.0_18" ubuntu 10.04
> Reporter: Ben Aldrich
> Assignee: Stefano Bagnara
> Fix For: 0.2
>
> Attachments: illegalargumentexception.txt
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> when calling validate I am seeing IllegalStateExceptions and
> IllegalArgumentException.
> It looks like we just need to catch these exceptions in the DKIMVerifier.java
> more specifically, in the verify method we need to add this around line 270 :
> } catch (IllegalArgumentException e) {
> throw new PermFailException(e.getMessage());
> and we should also add this in the signatureVerify method:
> try {
> signature.initVerify(key.getPublicKey());
> } catch (IllegalStateException e) {
> throw new PermFailException(e.getMessage());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
