Hi there, I just reviewed the code and you are right.. We should remove both methods form the interface (KISS). Could you open a jira issue to track the task ?
Thx, Norman 2010/9/21 Francois-Denis Gonthier <[email protected]>: > Hello all, > > I just implemented the deleteAll method in my store, but, just after, checked > how it is called from James. Outside the Memory store type, only the JPA > store really calls the deleteAll method but it is doing it through a method > that inside the JPAMailboxManager, which means it is specific to JPA. > > That means the deleteAll method is only used for tests, which I don't believe > justify its presence in the MailboxMapper interface. > > I wish somebody could explain me why I should implement this method. If > nobody can, I think it should be removed. > > The same can be said of findMailboxById except that it is not used *anywhere* > and that I have not implemented it because of that. > > -- > François-Denis Gonthier > Programmeur/analyste > 819-780-8955 #1128 http://www.revolutionlinux.com/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
