Author: norman
Date: Thu Dec 9 20:28:37 2010
New Revision: 1044120
URL: http://svn.apache.org/viewvc?rev=1044120&view=rev
Log:
Adjust logging to use info loglevel as the errors are more missusage then an
"real" error
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/MailCmdHandler.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/MailCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/MailCmdHandler.java?rev=1044120&r1=1044119&r2=1044120&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/MailCmdHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/MailCmdHandler.java
Thu Dec 9 20:28:37 2010
@@ -199,11 +199,11 @@ public class MailCmdHandler extends Abst
}
if (session.useAddressBracketsEnforcement()
&& (!sender.startsWith("<") || !sender.endsWith(">"))) {
- if (session.getLogger().isErrorEnabled()) {
+ if (session.getLogger().isInfoEnabled()) {
StringBuilder errorBuffer = new StringBuilder(128).append(
"Error parsing sender address: ").append(sender)
.append(": did not start and end with < >");
- session.getLogger().error(errorBuffer.toString());
+ session.getLogger().info(errorBuffer.toString());
}
return new SMTPResponse(SMTPRetCode.SYNTAX_ERROR_ARGUMENTS,
DSNStatus.getStatus(DSNStatus.PERMANENT,
@@ -231,12 +231,12 @@ public class MailCmdHandler extends Abst
try {
senderAddress = new MailAddress(sender);
} catch (Exception pe) {
- if (session.getLogger().isErrorEnabled()) {
+ if (session.getLogger().isInfoEnabled()) {
StringBuilder errorBuffer = new StringBuilder(256)
.append("Error parsing sender address: ")
.append(sender).append(": ").append(
pe.getMessage());
- session.getLogger().error(errorBuffer.toString());
+ session.getLogger().info(errorBuffer.toString());
}
return new SMTPResponse(SMTPRetCode.SYNTAX_ERROR_ARGUMENTS,
DSNStatus.getStatus(DSNStatus.PERMANENT,
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java?rev=1044120&r1=1044119&r2=1044120&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/RcptCmdHandler.java
Thu Dec 9 20:28:37 2010
@@ -122,12 +122,12 @@ public class RcptCmdHandler extends Abst
}
if (session.useAddressBracketsEnforcement()
&& (!recipient.startsWith("<") || !recipient.endsWith(">"))) {
- if (session.getLogger().isErrorEnabled()) {
+ if (session.getLogger().isInfoEnabled()) {
StringBuilder errorBuffer = new StringBuilder(192).append(
"Error parsing recipient address: ").append(
"Address did not start and end with < >").append(
getContext(session, null, recipient));
- session.getLogger().error(errorBuffer.toString());
+ session.getLogger().info(errorBuffer.toString());
}
return new SMTPResponse(SMTPRetCode.SYNTAX_ERROR_ARGUMENTS,
DSNStatus.getStatus(DSNStatus.PERMANENT,
@@ -151,12 +151,12 @@ public class RcptCmdHandler extends Abst
try {
recipientAddress = new MailAddress(recipient);
} catch (Exception pe) {
- if (session.getLogger().isErrorEnabled()) {
+ if (session.getLogger().isInfoEnabled()) {
StringBuilder errorBuffer = new StringBuilder(192).append(
"Error parsing recipient address: ").append(
getContext(session, recipientAddress, recipient))
.append(pe.getMessage());
- session.getLogger().error(errorBuffer.toString());
+ session.getLogger().info(errorBuffer.toString());
}
/*
* from RFC2822; 553 Requested action not taken: mailbox name
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java?rev=1044120&r1=1044119&r2=1044120&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/AuthCmdHandler.java
Thu Dec 9 20:28:37 2010
@@ -434,13 +434,13 @@ public class AuthCmdHandler
* @param initialResponse the initial response line passed in with the
AUTH command
*/
private SMTPResponse doUnknownAuth(SMTPSession session, String authType,
String initialResponse) {
- if (session.getLogger().isErrorEnabled()) {
+ if (session.getLogger().isInfoEnabled()) {
StringBuilder errorBuffer =
new StringBuilder(128)
.append("AUTH method ")
.append(authType)
.append(" is an unrecognized authentication type");
- session.getLogger().error(errorBuffer.toString());
+ session.getLogger().info(errorBuffer.toString());
}
return new SMTPResponse(SMTPRetCode.PARAMETER_NOT_IMPLEMENTED,
"Unrecognized Authentication Type");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
