Author: felixk
Date: Mon Mar 7 10:54:24 2011
New Revision: 1078742
URL: http://svn.apache.org/viewvc?rev=1078742&view=rev
Log:
Fix PROTOCOLS-19.
Copy the values for each array element will generate a new string object.
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java?rev=1078742&r1=1078741&r2=1078742&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/DNSRBLHandler.java
Mon Mar 7 10:54:24 2011
@@ -81,6 +81,12 @@ public class DNSRBLHandler implements C
* @param whitelist The array which contains the whitelist
*/
public void setWhitelist(String[] whitelist) {
+ // We need to copy the String array becuase of possible security
issues.
+ // Similar to https://issues.apache.org/jira/browse/PROTOCOLS-18
+ this.whitelist = new String[whitelist.length];
+ for (int i = 0; i < whitelist.length; i++) {
+ this.whitelist[i] = new String(whitelist[i]);
+ }
this.whitelist = whitelist;
}
@@ -90,7 +96,12 @@ public class DNSRBLHandler implements C
* @param blacklist The array which contains the blacklist
*/
public void setBlacklist(String[] blacklist) {
- this.blacklist = blacklist;
+ // We need to copy the String array becuase of possible security
issues.
+ // Similar to https://issues.apache.org/jira/browse/PROTOCOLS-18
+ this.blacklist = new String[blacklist.length];
+ for (int i = 0; i < blacklist.length; i++) {
+ this.blacklist[i] = new String(blacklist[i]);
+ }
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
