Author: felixk
Date: Tue Mar 22 10:29:02 2011
New Revision: 1084126
URL: http://svn.apache.org/viewvc?rev=1084126&view=rev
Log:
Some performance findings by findbugs report
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/VrfyCmdHandler.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/MailSizeEsmtpExtension.java
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java?rev=1084126&r1=1084125&r2=1084126&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java
Tue Mar 22 10:29:02 2011
@@ -42,7 +42,7 @@ import org.apache.mailet.MailAddress;
*/
public class DataCmdHandler implements CommandHandler<SMTPSession>,
ExtensibleHandler {
- public final class DataConsumerLineHandler implements
LineHandler<SMTPSession> {
+ public static final class DataConsumerLineHandler implements
LineHandler<SMTPSession> {
/*
* (non-Javadoc)
@@ -58,7 +58,7 @@ public class DataCmdHandler implements C
}
}
- public final class DataLineFilterWrapper implements
LineHandler<SMTPSession> {
+ public static final class DataLineFilterWrapper implements
LineHandler<SMTPSession> {
private DataLineFilter filter;
private LineHandler<SMTPSession> next;
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/VrfyCmdHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/VrfyCmdHandler.java?rev=1084126&r1=1084125&r2=1084126&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/VrfyCmdHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/VrfyCmdHandler.java
Tue Mar 22 10:29:02 2011
@@ -37,7 +37,7 @@ import org.apache.james.protocols.smtp.d
*/
public class VrfyCmdHandler implements CommandHandler<SMTPSession> {
- private final String COMMAND_NAME = "VRFY";
+ private static final String COMMAND_NAME = "VRFY";
/**
* Handler method called upon receipt of a VRFY command.
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/MailSizeEsmtpExtension.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/MailSizeEsmtpExtension.java?rev=1084126&r1=1084125&r2=1084126&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/MailSizeEsmtpExtension.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/MailSizeEsmtpExtension.java
Tue Mar 22 10:29:02 2011
@@ -126,7 +126,7 @@ public class MailSizeEsmtpExtension impl
} else {
// put the message size in the message state so it can be used
// later to restrict messages for user quotas, etc.
- session.getState().put(MESG_SIZE, new Integer(size));
+ session.getState().put(MESG_SIZE, Integer.valueOf(size));
}
return null;
}
@@ -149,9 +149,9 @@ public class MailSizeEsmtpExtension impl
Long currentSize = (Long)
session.getState().get("CURRENT_SIZE");
Long newSize;
if (currentSize == null) {
- newSize = new Long(line.length);
+ newSize = Long.valueOf(line.length);
} else {
- newSize = new Long(currentSize.intValue()+line.length);
+ newSize = Long.valueOf(currentSize.intValue()+line.length);
}
if (session.getMaxMessageSize() > 0 && newSize.intValue() >
session.getMaxMessageSize()) {
Modified:
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java?rev=1084126&r1=1084125&r2=1084126&view=diff
==============================================================================
---
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java
(original)
+++
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java
Tue Mar 22 10:29:02 2011
@@ -112,7 +112,7 @@ public class SpamTrapHandler implements
session.getLogger().debug("Add ip " + ip + " for " + bTime + " to
blockList");
synchronized(blockedIps) {
- blockedIps.put(ip, new Long(bTime));
+ blockedIps.put(ip, Long.valueOf(bTime));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
