Author: felixk
Date: Wed Mar 23 19:40:00 2011
New Revision: 1084692
URL: http://svn.apache.org/viewvc?rev=1084692&view=rev
Log:
Some speed ups
Modified:
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/base/ProtocolSession.java
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/builder/ScriptBuilder.java
Modified:
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/base/ProtocolSession.java
URL:
http://svn.apache.org/viewvc/james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/base/ProtocolSession.java?rev=1084692&r1=1084691&r2=1084692&view=diff
==============================================================================
---
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/base/ProtocolSession.java
(original)
+++
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/base/ProtocolSession.java
Wed Mar 23 19:40:00 2011
@@ -183,7 +183,7 @@ public class ProtocolSession {
/**
* A client request, which write the specified message to a Writer.
*/
- private class ClientRequest implements ProtocolElement {
+ private static class ClientRequest implements ProtocolElement {
private int sessionNumber;
private String message;
@@ -508,7 +508,7 @@ public class ProtocolSession {
* different from that expected.
*/
@SuppressWarnings("serial")
- public class InvalidServerResponseException extends Exception {
+ public static class InvalidServerResponseException extends Exception {
public InvalidServerResponseException(String message) {
super(message);
}
Modified:
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/builder/ScriptBuilder.java
URL:
http://svn.apache.org/viewvc/james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/builder/ScriptBuilder.java?rev=1084692&r1=1084691&r2=1084692&view=diff
==============================================================================
---
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/builder/ScriptBuilder.java
(original)
+++
james/mailbox-integration-tester/trunk/src/main/java/org/apache/james/imap/tester/builder/ScriptBuilder.java
Wed Mar 23 19:40:00 2011
@@ -434,15 +434,15 @@ public class ScriptBuilder {
}
public ScriptBuilder fetchSection(String section) throws Exception {
- final String body;
+ StringBuffer command = new StringBuffer("FETCH ");
+ command.append(messageNumber);
if (peek) {
- body = " (BODY.PEEK[";
+ command.append(" (BODY.PEEK[");
} else {
- body = " (BODY[";
+ command.append(" (BODY[");
}
- final String command = "FETCH " + messageNumber + body + section + "]"
- + partialFetch + ")";
- command(command);
+ command.append(section).append("]").append(partialFetch).append(")");
+ command(command.toString());
return this;
}
@@ -647,9 +647,9 @@ public class ScriptBuilder {
public String command() {
if (uidSearch) {
- return "UID SEARCH " + buffer.toString();
+ return buffer.insert(0, "UID SEARCH ").toString();
} else {
- return "SEARCH " + buffer.toString();
+ return buffer.insert(0, "SEARCH ").toString();
}
}
@@ -659,7 +659,7 @@ public class ScriptBuilder {
}
private Search append(long term) {
- return append(new Long(term).toString());
+ return append(Long.valueOf(term).toString());
}
private Search append(String term) {
@@ -1019,31 +1019,31 @@ public class ScriptBuilder {
}
public String buildBody(boolean peek, String section) {
- String result;
+ StringBuffer result;
if (peek) {
- result = "BODY.PEEK[";
+ result = new StringBuffer("BODY.PEEK[");
} else {
- result = "BODY[";
+ result = new StringBuffer("BODY[");
}
- result = result + section + "]";
- return result;
+ result.append(section).append("]");
+ return result.toString();
}
public String buildHeaderFields(String[] fields, boolean not) {
- String result;
+ StringBuffer result;
if (not) {
- result = "HEADER.FIELDS.NOT (";
+ result = new StringBuffer("HEADER.FIELDS.NOT (");
} else {
- result = "HEADER.FIELDS (";
+ result = new StringBuffer("HEADER.FIELDS (");
}
for (int i = 0; i < fields.length; i++) {
if (i > 0) {
- result = result + " ";
+ result.append(" ");
}
- result = result + fields[i];
+ result.append(fields[i]);
}
- result = result + ")";
- return result;
+ result.append(")");
+ return result.toString();
}
public String fetchData() {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
